netdev - Re: [PATCH net-next v2 2/3] virtio net: Handle proto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150323.165001.2063467454200119106.davem@davemloft.net>
Date:	Mon, 23 Mar 2015 16:50:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	anuradhak@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, roopa@...ulusnetworks.com,
	gospo@...ulusnetworks.com, wkok@...ulusnetworks.com
Subject: Re: [PATCH net-next v2 2/3] virtio net: Handle proto_down state by
 setting the carrier off.

From: anuradhak@...ulusnetworks.com
Date: Sat, 21 Mar 2015 21:06:57 -0700

> From: Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
> 
> Applications such as MLAG can detect errors in the network which results
> in IFF_PROTO_DOWN being set. This patch adds support for handling
> proto_down for virtio drivers by turning off the carrier and stopping
> netif processing.
> 
> Signed-off-by: Anuradha Karuppiah <anuradhak@...ulusnetworks.com>
> Signed-off-by: Andy Gospodarek <gospo@...ulusnetworks.com>
> Signed-off-by: Roopa Prabhu <roopa@...ulusnetworks.com>
> Signed-off-by: Wilson Kok <wkok@...ulusnetworks.com>

I really don't like the idea that there are potentially many drivers
that will not have to add this kind of new code.

This doesn't scale when you have dozens of software devices of various
types, and several hundred physical hardware networking drivers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html