netdev - Re: [PATCH net-next] vxlan: simplify if clause in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150323.170230.104062959694514151.davem@davemloft.net>
Date:	Mon, 23 Mar 2015 17:02:30 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	marcelo.leitner@...il.com
Cc:	netdev@...r.kernel.org, dan.carpenter@...cle.com,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net-next] vxlan: simplify if clause in dev_close

From: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Date: Mon, 23 Mar 2015 16:23:12 -0300

> Dan Carpenter's static checker warned that in vxlan_stop we are checking
> if 'vs' can be NULL while later we simply derreference it.
> 
> As after commit 56ef9c909b40 ("vxlan: Move socket initialization to
> within rtnl scope") 'vs' just cannot be NULL in vxlan_stop() anymore, as
> the interface won't go up if the socket initialization fails. So we are
> good to just remove the check and make it consistent.
> 
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html