netdev - Re: [PATCH net] rocker: handle non-bridge master change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150323065353.GA16565@vergenet.net>
Date:	Mon, 23 Mar 2015 15:53:55 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	Jiri Pirko <jiri@...nulli.us>
Cc:	Scott Feldman <sfeldma@...il.com>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] rocker: handle non-bridge master change

On Mon, Mar 23, 2015 at 07:23:09AM +0100, Jiri Pirko wrote:
> Mon, Mar 23, 2015 at 07:13:21AM CET, simon.horman@...ronome.com wrote:
> >Master change notifications may occur other than when joining or
> >leaving a bridge, for example when being added to or removed from
> >a bond or Open vSwitch.
> >
> >Previously in those cases rocker_port_bridge_leave() was called
> >which results in a null-pointer dereference as rocker_port->bridge_dev
> >is NULL because there is no bridge device.
> >
> >This patch makes provision for doing nothing in such cases.
> >
> >Fixes: 6c7079450071f ("rocker: implement L2 bridge offloading")
> >Signed-off-by: Simon Horman <simon.horman@...ronome.com>
> 
> Acked-by: Jiri Pirko <jiri@...nulli.us>

I would like to clarify that I lightly tested this patch to the
extent that I no longer see a null-pointer dereference.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html