netdev - Re: [v2 PATCH 4/10] netlink: Use default rhashtable hashfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150323011817.GC20755@vergenet.net>
Date:	Mon, 23 Mar 2015 10:18:21 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Thomas Graf <tgraf@...g.ch>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Patrick McHardy <kaber@...sh.net>,
	Josh Triplett <josh@...htriplett.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	netdev@...r.kernel.org
Subject: Re: [v2 PATCH 4/10] netlink: Use default rhashtable hashfn

Hi Herbert,

On Sun, Mar 22, 2015 at 07:04:02PM +1100, Herbert Xu wrote:
> This patch removes the explicit jhash value for the hashfn parameter
> of rhashtable.  The default is now jhash so removing the setting
> makes no difference apart from making one less copy of jhash in
> the kernel.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>
> ---
> 
>  net/netlink/af_netlink.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 6517921..e2f7f28 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -3133,13 +3133,12 @@ static inline u32 netlink_hash(const void *data, u32 seed)
>  	struct netlink_compare_arg arg;
>  
>  	netlink_compare_arg_init(&arg, sock_net(&nlk->sk), nlk->portid);
> -	return jhash(&arg, netlink_compare_arg_len, seed);
> +	return jhash2((u32 *)&arg, netlink_compare_arg_len / sizeof(u32), seed);

I understand the above change in the context of the rest of the series,
however, it does not seem to match up with the changelog for this patch.

>  }
>  
>  static const struct rhashtable_params netlink_rhashtable_params = {
>  	.head_offset = offsetof(struct netlink_sock, node),
>  	.key_len = netlink_compare_arg_len,
> -	.hashfn = jhash,
>  	.obj_hashfn = netlink_hash,
>  	.obj_cmpfn = netlink_compare,
>  	.max_size = 65536,
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html