netdev - Re: [PATCH] ucc_geth: Intialize link state to down before register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF515B2C92.39F94674-ON88257E12.00676FA3-88257E12.00679D6B@selinc.com>
Date:	Tue, 24 Mar 2015 11:51:44 -0700
From:	cliff_clark@...inc.com
To:	Li Yang <leoli@...escale.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ucc_geth: Intialize link state to down before register_netdev

ucc_geth was indicating link up after a port is administratively enabled 
even
when nothing is plugged in.  This causes user-space tools to see a 
spurious link
up the first time after boot.

Signed-off-by: Cliff Clark <cliff_clark@...inc.com>
---
 drivers/net/ethernet/freescale/ucc_geth.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/freescale/ucc_geth.c 
b/drivers/net/ethernet/freescale/ucc_geth.c
index 357e8b57..56b774d 100644
--- a/drivers/net/ethernet/freescale/ucc_geth.c
+++ b/drivers/net/ethernet/freescale/ucc_geth.c
@@ -3893,6 +3893,9 @@ static int ucc_geth_probe(struct platform_device* 
ofdev)
        ugeth->phy_interface = phy_interface;
        ugeth->max_speed = max_speed;
 
+       /* Carrier starts down, phylib will bring it up */
+       netif_carrier_off(dev);
+
        err = register_netdev(dev);
        if (err) {
                if (netif_msg_probe(ugeth))
-- 
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html