netdev - Re: [PATCH v2] iproute2: Fix -o (oneline) being broken in xfrm & correct mark radix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Mar 2015 15:02:18 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Philip Prindeville <philipp@...fish-solutions.com>
Cc:	netdev@...r.kernel.org, Alexy Kuznetsov <kuznet@....inr.ac.ru>
Subject: Re: [PATCH v2] iproute2: Fix -o (oneline) being broken in xfrm &
 correct mark radix

On Thu, 19 Mar 2015 13:54:28 -0600
Philip Prindeville <philipp@...fish-solutions.com> wrote:

> Don't insert newline in -o (oneline) mode; print mark as hex.
> 
> Oneline mode is supposed to force all output to be on oneline and
> machine-parsable, but this isn't the case for "ip xfrm" as shown:
> 
> % ip -o xfrm monitor
> ...
> src 0.0.0.0/0 dst 0.0.0.0/0 \   dir out priority 2051 ptype main \  mark -1879048191/0xffffffff
>     tmpl src 203.0.130.10 dst 198.51.130.30\        proto esp reqid 16384 mode tunnel\
> ...
> 
> as that's 2 lines, not one. Also, the "mark" is shown in signed
> decimal, but the mask is in hex. This is confusing: let's use
> hex for both.
> 
> Signed-off-by: Philip Prindeville <philipp@...fish-solutions.com>

Applied to master. Thanks
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html