netdev - Re: rhashtable: warnings caused by "rhashtable: Fix use-after-free in rhashtable_walk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150323.221624.2222527689667678224.davem@davemloft.net>
Date:	Mon, 23 Mar 2015 22:16:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	sasha.levin@...cle.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, tgraf@...g.ch
Subject: Re: rhashtable: warnings caused by "rhashtable: Fix use-after-free
 in rhashtable_walk_stop"

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Tue, 24 Mar 2015 09:53:17 +1100

> rhashtable: Fix sleeping inside RCU critical section in walk_stop
> 
> The commit 963ecbd41a1026d99ec7537c050867428c397b89 ("rhashtable:
> Fix use-after-free in rhashtable_walk_stop") fixed a real bug
> but created another one because we may end up sleeping inside an
> RCU critical section.
> 
> This patch fixes it properly by replacing the mutex with a spin
> lock that specifically protects the walker lists.
> 
> Reported-by: Sasha Levin <sasha.levin@...cle.com>
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks everyone.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html