netdev - Re: [PATCH] tipc: validate length of sockaddr in connect() for dgram/rdm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55112A30.2050800@windriver.com>
Date:	Tue, 24 Mar 2015 17:11:12 +0800
From:	Ying Xue <ying.xue@...driver.com>
To:	Sasha Levin <sasha.levin@...cle.com>,
	<linux-kernel@...r.kernel.org>
CC:	<erik.hugne@...csson.com>, <jon.maloy@...csson.com>,
	<davem@...emloft.net>,
	Allan Stephens <allan.stephens@...driver.com>, open list:
	TIPC NETWORK LAYER <netdev@...r.kernel.org>, ; open list:
	TIPC NETWORK LAYER <tipc-discussion@...ts.sourceforge.net>, ;
Subject: Re: [PATCH] tipc: validate length of sockaddr in connect() for dgram/rdm

On 03/24/2015 03:30 AM, Sasha Levin wrote:
> Commit f2f8036 ("tipc: add support for connect() on dgram/rdm sockets")
> hasn't validated user input length for the sockaddr structure which allows
> a user to overwrite kernel memory with arbitrary input.
> 
> Fixes: f2f8036 ("tipc: add support for connect() on dgram/rdm sockets")
> Signed-off-by: Sasha Levin <sasha.levin@...cle.com>

Acked-by: Ying Xue <ying.xue@...driver.com>

> ---
>  net/tipc/socket.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index 73c2f51..986dc96 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -1852,6 +1852,8 @@ static int tipc_connect(struct socket *sock, struct sockaddr *dest,
>  		if (dst->family == AF_UNSPEC) {
>  			memset(&tsk->remote, 0, sizeof(struct sockaddr_tipc));
>  			tsk->connected = 0;
> +		} else if (destlen != sizeof(struct sockaddr_tipc)) {
> +			res = -EINVAL;
>  		} else {
>  			memcpy(&tsk->remote, dest, destlen);
>  			tsk->connected = 1;
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html