[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150323.214114.813876422885118707.davem@davemloft.net>
Date: Mon, 23 Mar 2015 21:41:14 -0400 (EDT)
From: David Miller <davem@...emloft.net>
To: eric.dumazet@...il.com
Cc: fengyuleidian0615@...il.com, erik.hugne@...csson.com,
netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] inet: fix double request socket freeing
From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 23 Mar 2015 15:00:41 -0700
> From: Fan Du <fan.du@...el.com>
>
> Eric Hugne reported following error :
>
> I'm hitting this warning on latest net-next when i try to SSH into a machine
> with eth0 added to a bridge (but i think the problem is older than that)
>
> Steps to reproduce:
> node2 ~ # brctl addif br0 eth0
> [ 223.758785] device eth0 entered promiscuous mode
> node2 ~ # ip link set br0 up
> [ 244.503614] br0: port 1(eth0) entered forwarding state
> [ 244.505108] br0: port 1(eth0) entered forwarding state
...
> Remove the double calls to reqsk_put()
>
> [edumazet] :
>
> I got confused because reqsk_timer_handler() _has_ to call
> reqsk_put(req) after calling inet_csk_reqsk_queue_drop(), as
> the timer handler holds a reference on req.
>
> Signed-off-by: Fan Du <fan.du@...el.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Erik Hugne <erik.hugne@...csson.com>
> Fixes: fa76ce7328b2 ("inet: get rid of central tcp/dccp listener timer")
Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists