netdev - Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427322394.25985.128.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 25 Mar 2015 15:26:34 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexey Kodanev <alexey.kodanev@...cle.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: tcp6: fix double call of tcp_v6_fill_cb()

On Thu, 2015-03-26 at 00:25 +0300, Alexey Kodanev wrote:

> Did various testing with exactly that change and hadn't found any 
> "serious performance impact" on the stack (at least on my configuration).

Sure, but nobody will take the risk to make such change without serious
tests on multiple workloads and arches.

> 
> Alright, what about other part of the patch, is it acceptable?
> 
> I came up with one more solution... not so radical :)
> We can restore inet6_skb_parm with
> 
>      memmove(IP6CB(skb), &TCP_SKB_CB(skb)->header.h6, ...)
> 
> in the two places in tcp_v6_rcv(), before xfrm6_policy_check() + 
> tcp_v6_fill_cb() are called again:
> 
>   static int tcp_v6_rcv(struct sk_buff *skb)
>   {
>          const struct tcphdr *th;
> @@ -1543,6 +1552,7 @@ do_time_wait:
>                          inet_twsk_deschedule(tw, &tcp_death_row);
>                          inet_twsk_put(tw);
>                          sk = sk2;
> +                       tcp_v6_restore_cb(skb);
>                          goto process;
>                  }
>                  /* Fall through to ACK */
> @@ -1551,6 +1561,7 @@ do_time_wait:
>                  tcp_v6_timewait_ack(sk, skb);
>                  break;
>          case TCP_TW_RST:
> +               tcp_v6_restore_cb(skb);
>                  goto no_tcp_socket;
>          case TCP_TW_SUCCESS:
> 

Looks good to me !




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html