netdev - Re: [PATCH] iproute2: enhance addr label validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150325002309.GF23124@vergenet.net>
Date:	Wed, 25 Mar 2015 09:23:11 +0900
From:	Simon Horman <simon.horman@...ronome.com>
To:	Joe Harvell <joe.harvell@...comms.com>
Cc:	netdev@...r.kernel.org, Stephen Hemminger <shemming@...cade.com>,
	Vadim Kochan <vadim4j@...il.com>
Subject: Re: [PATCH] iproute2: enhance addr label validation

Hi Joe,

On Mon, Mar 23, 2015 at 09:02:47AM -0500, Joe Harvell wrote:
> >Hi Joe,
> >
> >On Sat, Mar 21, 2015 at 03:14:53PM -0500, Joe Harvell wrote:
> >>The ip addr command today rejects address labels that would break
> >>ifconfig.  However, it allows some labels which still break it. Enhance
> >>enforcement to reject all known incompatible labels, and allow the
> >>existing -force option to allow someone to use a label even if it is not
> >>ifconfig compatible
> >I am concerned this will break existing users who are relying on setting
> >labels that would now be rejected without using -force.
> >
> [snip]
> 
> Simon,
> 
> Good point.  I propose the following:
> 
> When a label is specified without -force, and that label begins with the
> interface name but is followed by something other than a colon, accept
> the label but emit a warning message indicating this label is
> incompatible with ifconfig and that later versions of the 'ip address'
> command may reject it.  This message can also indicate that -force can be
> specified to explicitly indicate a label that is non ifconfig compatible
> is desired.
> 
> At some point in the future, the behavior could then be changed to reject
> such labels.
> 
> What do you think?

That sounds entirely reasonable to me.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html