netdev - Re: [PATCH v4 1/3] net: add support for phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150325063751.GA2034@nanopsycho.orion>
Date:	Wed, 25 Mar 2015 07:37:51 +0100
From:	Jiri Pirko <jiri@...nulli.us>
To:	David Ahern <dsahern@...il.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	netdev@...r.kernel.org, sfeldma@...il.com
Subject: Re: [PATCH v4 1/3] net: add support for phys_port_name

Tue, Mar 24, 2015 at 11:25:12PM CET, dsahern@...il.com wrote:
>On 3/24/15 4:13 PM, Stephen Hemminger wrote:
>>On Tue, 17 Mar 2015 20:23:15 -0600
>>David Ahern <dsahern@...il.com> wrote:
>>
>>>Similar to port id allow netdevices to specify port names and export
>>>the name via sysfs. Drivers can implement the netdevice operation to
>>>assist udev in having sane default names for the devices using the
>>>rule:
>>>
>>>$ cat /etc/udev/rules.d/80-net-setup-link.rules
>>>SUBSYSTEM=="net", ACTION=="add", ATTR{phys_port_name}!="",
>>>NAME="$attr{phys_port_name}"
>>>
>>>Use of phys_name versus phys_id was suggested-by Jiri Pirko.
>>>
>>>Signed-off-by: David Ahern <dsahern@...il.com>
>>>Acked-by: Jiri Pirko <jiri@...nulli.us>
>>>Acked-by: Scott Feldman <sfeldma@...il.com>
>>
>>Should this also be settable as well?
>>
>>
>
>The intention was for this to come from the device. Currently, phys_port_id
>and phys_port_name only have get methods, so no set.

Makes no sense to have set for these two.

>
>David
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html