netdev - Re: [PATCH net-next 1/2] ipv4: hash net ptr into fragmentation bucket selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1427296586.2333772.245087045.6283C1D9@webmail.messagingengine.com>
Date:	Wed, 25 Mar 2015 16:16:26 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Flavio Leitner <fbl@...hat.com>
Subject: Re: [PATCH net-next 1/2] ipv4: hash net ptr into fragmentation bucket
 selection



On Wed, Mar 25, 2015, at 15:45, Eric Dumazet wrote:
> On Wed, 2015-03-25 at 15:00 +0100, Hannes Frederic Sowa wrote:
> > As namespaces are sometimes used with overlapping ip address ranges,
> > we should also use the namespace as input to the hash to select the ip
> > fragmentation counter bucket.
> > 
> > Cc: Eric Dumazet <edumazet@...gle.com>
> > Cc: Flavio Leitner <fbl@...hat.com>
> > Signed-off-by: Hannes Frederic Sowa <hannes@...essinduktion.org>
> > ---
> >  drivers/net/ppp/pptp.c          | 2 +-
> >  net/netfilter/ipvs/ip_vs_xmit.c | 5 +++--
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/net/ppp/pptp.c b/drivers/net/ppp/pptp.c
> > index 1dc628f..e3bfbd4d 100644
> > --- a/drivers/net/ppp/pptp.c
> > +++ b/drivers/net/ppp/pptp.c
> > @@ -281,7 +281,7 @@ static int pptp_xmit(struct ppp_channel *chan, struct sk_buff *skb)
> >  	nf_reset(skb);
> >  
> >  	skb->ip_summed = CHECKSUM_NONE;
> > -	ip_select_ident(skb, NULL);
> > +	ip_select_ident(sock_net(sk), skb, NULL);
> >  	ip_send_check(iph);
> >  
> 
> I do not see how this would compile, without corresponding change in
> ip_select_ident() ?

Cheers! ;)

We have a very slow coffee machine, so while waiting for a new one to be
produced I forgot to squash the ipv4 commits and just send them out.

> Or maybe I should drink this coffee ;)
> 
> Really, Redhat should tell truth to its customers : frags are bad

We still have to support Google's DNS servers, too. ;)

Bye,
Hannes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html