netdev - Re: [PATCH net-next v2 1/2] ipv4: hash net ptr into fragmentation bucket selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1427297653.25985.116.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 25 Mar 2015 08:34:13 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Hannes Frederic Sowa <hannes@...essinduktion.org>
Cc:	netdev@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
	Flavio Leitner <fbl@...hat.com>
Subject: Re: [PATCH net-next v2 1/2] ipv4: hash net ptr into fragmentation
 bucket selection

On Wed, 2015-03-25 at 15:18 +0100, Hannes Frederic Sowa wrote:

>  	hash = jhash_3words((__force u32)iph->daddr,
>  			    (__force u32)iph->saddr,
> -			    iph->protocol,
> +			    iph->protocol | (net_hash_mix(net) << 8),
>  			    ip_idents_hashrnd);


I would rather use 

iph->protocol ^ net_hash_mix(net)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html