netdev - Re: [PATCH net] ipvlan: fix addr hash list corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150325.114622.1915164845375005128.davem@davemloft.net>
Date:	Wed, 25 Mar 2015 11:46:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	maheshb@...gle.com, netdev@...r.kernel.org, dcbw@...hat.com
Subject: Re: [PATCH net] ipvlan: fix addr hash list corruption

From: Jiri Benc <jbenc@...hat.com>
Date: Wed, 25 Mar 2015 09:58:51 +0100

> On Tue, 24 Mar 2015 16:16:38 -0700, Mahesh Bandewar wrote:
>> Well, we already have hlist_unhashed().The following patch should fix
>> the duplicate addition as well as deletion. Please give it a try.
> 
> Good idea, it's surely better than adding a new boolean.
> 
> However, I'm wondering that when there's apparently no problem with the
> addresses being on the hash list when interface is down, what's the
> point in clearing the hash list in the ndo_stop handler and
> repopulating it in ndo_open?
> 
> The following patch fixes the problem, too, and as a bonus removes code:

I'll let Mahesh reply to this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html