netdev - Re: [PATCH net 2/2] cxgb4: Disable interrupts and napi before unregistering netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <551473D6.2050406@gmx.de>
Date:	Thu, 26 Mar 2015 22:02:14 +0100
From:	Lino Sanfilippo <LinoSanfilippo@....de>
To:	Hariprasad Shenai <hariprasad@...lsio.com>, netdev@...r.kernel.org
CC:	davem@...emloft.net, leedom@...lsio.com, anish@...lsio.com,
	nirranjan@...lsio.com, kumaras@...lsio.com,
	swise@...ngridcomputing.com
Subject: Re: [PATCH net 2/2] cxgb4: Disable interrupts and napi before unregistering
 netdev

Hi,

On 26.03.2015 05:34, Hariprasad Shenai wrote:
> Disable interrupts and quiesce rx before unregistering net device to avoid crash
> while unloading driver when traffic is flowing through.
> 
> Based on original work by Shameem Khalid <shameem@...lsio.com>
> 

just out of curiousity: How can an unregister of a netdevice lead to a
crash caused by traffic? I understand that _freeing_ the device or other
resources is a bad idea as long as irqs are still active. But unregister
should not do anything critical (i am asking since I want to avoid such
problems in my own drivers).

Regards,
Lino
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html