[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150326132532.GB20404@casper.infradead.org>
Date: Thu, 26 Mar 2015 13:25:32 +0000
From: Thomas Graf <tgraf@...g.ch>
To: Jiri Pirko <jiri@...nulli.us>
Cc: netdev@...r.kernel.org, davem@...emloft.net, jhs@...atatu.com,
jesse@...ira.com
Subject: Re: [patch net-next] tc: introduce OpenFlow classifier
On 03/26/15 at 01:53pm, Jiri Pirko wrote:
> This patch introduces OpenFlow-based filter. So far, the very essential
> packet fields are supported (according to OpenFlow v1.4 spec).
>
> This patch is only the first step. There is a lot of potential performance
> improvements possible to implement. Also a lot of features are missing
> now. They will be addressed in follow-up patches.
>
> To the name of this classifier, I believe that "cls_openflow" is pretty
> accurate. It is actually a OpenFlow classifier.
My feedback on this was that this could be misleading because
cls_openflow does not make the kernel an OpenFlow switch (neither
does OVS). I can see the relation to some of the match fields as
specified by OpenFlow but there is no relation to the wire protocol
itself or any of the other OpenFlow specific concepts such as flow
tables, group tables, counters, actions, etc.
That said, I can see what you mean by it and I think if we make this
clear in the description and manual page that might be enough to
avoid confusion.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists