netdev - Re: [PATCH net-next 3/7] net: Move check for multiple vlans to drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 14:28:54 +0900
From:	Toshiaki Makita <makita.toshiaki@....ntt.co.jp>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	"David S . Miller" <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>,
	Ariel Elior <ariel.elior@...gic.com>,
	Amir Vadai <amirv@...lanox.com>,
	Shahed Shaikh <shahed.shaikh@...gic.com>,
	Dept-GELinuxNICDev@...gic.com, Jay Vosburgh <j.vosburgh@...il.com>,
	Veaceslav Falico <vfalico@...il.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Linux NICS <linux.nics@...el.com>,
	Vlad Yasevich <vyasevic@...hat.com>, netdev@...r.kernel.org,
	e1000-devel@...ts.sourceforge.net
Subject: Re: [PATCH net-next 3/7] net: Move check for multiple vlans to drivers

On 2015/03/26 20:55, Eric Dumazet wrote:
...
>> +/**
>> + * vlan_features_check - drop unsafe features for skb with multiple tags.
>> + * @skb: skbuff to query
>> + * @features: features to be checked
>> + *
>> + * Returns features without unsafe ones if the skb has multiple tags.
>> + */
>> +static inline netdev_features_t vlan_features_check(struct sk_buff *skb,
> 
> const struct sk_buff *skb
> 
>> +						    netdev_features_t features)
>> +{
>> +	if (skb_vlan_tagged_multi(skb))
...
>> @@ -2562,6 +2562,13 @@ static netdev_features_t harmonize_features(struct sk_buff *skb,
>>  	return features;
>>  }
>>  
>> +static netdev_features_t dflt_features_check(struct sk_buff *skb,
> 
> const struct sk_buff *skb

Thank you, I fixed them and your another feedback for patch 2.
will send v2.

Toshiaki Makita

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html