netdev - Re: [RFC net-next 1/2] net: allow user to set IPv6 nexthop for IPv4 route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Mar 2015 10:10:57 -0400
From:	Andy Gospodarek <gospo@...ulusnetworks.com>
To:	Robert Shearman <rshearma@...cade.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Bjornar Ness <bjornar.ness@...il.com>,
	Sowmini Varadhan <sowmini05@...il.com>,
	Eric Dumazet <eric.dumazet@...il.com>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [RFC net-next 1/2] net: allow user to set IPv6 nexthop for IPv4
 route

On Fri, Mar 27, 2015 at 11:53:01AM +0000, Robert Shearman wrote:
> On 26/03/15 21:05, Andy Gospodarek wrote:
> >diff --git a/include/uapi/linux/rtnetlink.h b/include/uapi/linux/rtnetlink.h
> >index bea910f..26cdd01 100644
> >--- a/include/uapi/linux/rtnetlink.h
> >+++ b/include/uapi/linux/rtnetlink.h
> >@@ -306,6 +306,7 @@ enum rtattr_type_t {
> >         RTA_VIA,
> >         RTA_NEWDST,
> >         RTA_PREF,
> >+       RTA_GATEWAY6,
> 
> There shouldn't be any need to add a new attribute. The RTA_VIA attribute
> that Eric Biederman recently introduced should have the semantics that you
> require:
> 
> "RTA_VIA specifies the specifies the next machine to send a packet to
> like RTA_GATEWAY.  RTA_VIA differs from RTA_GATEWAY in that it
> includes the address family of the address of the next machine to send
> a packet to."

Absolutely.  I did this first set before Eric added the RTA_VIA
attribute, so I need to not only use it, but also add support in the
ipv4 code to use that attribute if set.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html