netdev - Re: [PATCH resend] Renesas Ethernet AVB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55163959.8080101@gmx.de>
Date:	Sat, 28 Mar 2015 06:17:13 +0100
From:	Lino Sanfilippo <LinoSanfilippo@....de>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	robh+dt@...nel.org, pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, devicetree@...r.kernel.org,
	galak@...eaurora.org, netdev@...r.kernel.org
CC:	linux-sh@...r.kernel.org
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver

Hi,

On 28.03.2015 00:13, Sergei Shtylyov wrote:

> +	spinlock_t lock;		/* Register access lock */

Do you really need one huge lock for all register accesses? Maybe you
should rethink which registers can actually be accessed concurrently and
implement some finer grained locking.

Regards,
Lino
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html