netdev - Re: [PATCH net 1/4 v2] ipvlan: fix addr hash list corruption

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150329.122325.255412967371199514.davem@davemloft.net>
Date:	Sun, 29 Mar 2015 12:23:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, maheshb@...gle.com, dcbw@...hat.com
Subject: Re: [PATCH net 1/4 v2] ipvlan: fix addr hash list corruption

From: Jiri Benc <jbenc@...hat.com>
Date: Fri, 27 Mar 2015 18:30:23 +0100

> @@ -622,7 +622,10 @@ static int ipvlan_add_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>  	addr->atype = IPVL_IPV6;
>  	list_add_tail_rcu(&addr->anode, &ipvlan->addrs);
>  	ipvlan->ipv6cnt++;
> -	ipvlan_ht_addr_add(ipvlan, addr);
> +	/* If the interface is not up, the address will be added to the hash
> +	 * list by ipvlan_open. */

Comments in the networking should be formatted:

	/* Like
	 * this.
	 */

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html