netdev - Re: [PATCH net-next 00/18] switchdev: spring cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Mar 2015 19:11:21 +0300
From:	Or Gerlitz <gerlitz.or@...il.com>
To:	roopa <roopa@...ulusnetworks.com>,
	Andy Gospodarek <gospo@...ulusnetworks.com>,
	Jiri Pirko <jiri@...nulli.us>,
	Scott Feldman <sfeldma@...il.com>
Cc:	Linux Netdev List <netdev@...r.kernel.org>, linux@...ck-us.net,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH net-next 00/18] switchdev: spring cleanup

On Mon, Mar 30, 2015 at 6:00 PM, roopa <roopa@...ulusnetworks.com> wrote:
> On 3/30/15, 6:11 AM, Andy Gospodarek wrote:
>>
>> On Mon, Mar 30, 2015 at 02:00:25PM +0200, Jiri Pirko wrote:
>>>
>>> Mon, Mar 30, 2015 at 10:40:18AM CEST, sfeldma@...il.com wrote:
>>>>
>>>> From: Scott Feldman <sfeldma@...il.com>
>>>>
>>>> The main theme of this patch set is to cleanup swdev in preparation for
>>>> new features or fixes to be added soon.  We have a pretty good idea now
>>>> how
>>>> to handle stacked drivers in swdev, but there where some loose ends.
>>>> For
>>>> example, if a set failed in the middle of walking the lower devs, we
>>>> would
>>>> leave the system in an undefined state...there was no way to recover
>>>> back to
>>>> the previous state.  Speaking of sets, also recognize a pattern that
>>>> most
>>>> swdev API accesses are gets or sets of port attributes, so go ahead and
>>>> make
>>>> port attr get/set the central swdev API, and convert everything that is
>>>> set-ish/get-ish to this new API.
>>>>
>>>> Features/fixes that should follow from this cleanup:
>>>>
>>>> - solve the duplicate pkt forwarding issue
>>>> - get/set bridge attrs, like ageing_time, from/to device
>>>> - get/set more bridge port attrs from/to device
>>>>
>>>> There are some rename cleanups tagging along at the end, to give swdev
>>>> consistent naming.
>>>
>>> As you can see in the switchdev patch submission history, I originally
>>> pushed this with "swdev_" previx. Turned out people did not like that
>>> because "sw" can be easily misunderstood as "software".
>>
>> I agree with this.
>>
> agree. maybe just "switchdev_" will be better.

Also, how about prefixing the ops names supported by switchdev with
"sdo_" e.g as we have ndo_ prefix for "plain" netdevs?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html