netdev - Re: [PATCH 1/1] ip-link: allow human readable output with base of 1024 only for byte counts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150330090315.68ce923d@leda.localdomain>
Date:	Mon, 30 Mar 2015 09:03:15 +0200
From:	Christian Hesse <list@...rm.de>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	netdev@...r.kernel.org, Christian Hesse <mail@...rm.de>
Subject: Re: [PATCH 1/1] ip-link: allow human readable output with base of
 1024 only for byte counts

Stephen Hemminger <stephen@...workplumber.org> on Sun, 2015/03/29 22:58:
> On Thu, 26 Mar 2015 12:24:08 +0100
> Christian Hesse <list@...rm.de> wrote:
> 
> > From: Christian Hesse <mail@...rm.de>
> > 
> > Counting bytes with a base of 1024 is ok. Counting packets, errors, etc
> > that way makes no sense.
> > So only print byte counts with a base of 1024 if option -iec is given.
> > 
> > Signed-off-by: Christian Hesse <mail@...rm.de>
> 
> This changes the output which users expect, especially the packet counts
> should follow existing practice. And I doubt anyone would have 1024 errors.

With current code you can give -iec and everything (including errors) is
printed with IEC units. This patch changes it to only print byte counts with
IEC units, so error will be displayed with a base of 1000 always.

I think my patch changes things to what user expects, no?
-- 
main(a){char*c=/*    Schoene Gruesse                         */"B?IJj;MEH"
"CX:;",b;for(a/*    Chris           get my mail address:    */=0;b=c[a++];)
putchar(b-1/(/*               gcc -o sig sig.c && ./sig    */b/42*2-3)*42);}

Content of type "application/pgp-signature" skipped