netdev - Re: [PATCH net] netlink: pad nla_memcpy dest buffer with zeroes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150330113130.GA28989@casper.infradead.org>
Date:	Mon, 30 Mar 2015 12:31:30 +0100
From:	Thomas Graf <tgraf@...g.ch>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net] netlink: pad nla_memcpy dest buffer with zeroes

On 03/29/15 at 04:05pm, Jiri Benc wrote:
> This is especially important in cases where the kernel allocs a new
> structure and expects a field to be set from a netlink attribute. If such
> attribute is shorter than expected, the rest of the field is left containing
> previous data. When such field is read back by the user space, kernel memory
> content is leaked.
> 
> Signed-off-by: Jiri Benc <jbenc@...hat.com>

I think it is safe to assume that the caller intents to get all
of the destination buffer filled just as memcpy() would do.

Acked-by: Thomas Graf <tgraf@...g.ch>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html