| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20150330131049.GI1051@gospo> Date: Mon, 30 Mar 2015 09:11:23 -0400 From: Andy Gospodarek <gospo@...ulusnetworks.com> To: Jiri Pirko <jiri@...nulli.us> Cc: sfeldma@...il.com, netdev@...r.kernel.org, roopa@...ulusnetworks.com, linux@...ck-us.net, f.fainelli@...il.com Subject: Re: [PATCH net-next 00/18] switchdev: spring cleanup On Mon, Mar 30, 2015 at 02:00:25PM +0200, Jiri Pirko wrote: > Mon, Mar 30, 2015 at 10:40:18AM CEST, sfeldma@...il.com wrote: > >From: Scott Feldman <sfeldma@...il.com> > > > >The main theme of this patch set is to cleanup swdev in preparation for > >new features or fixes to be added soon. We have a pretty good idea now how > >to handle stacked drivers in swdev, but there where some loose ends. For > >example, if a set failed in the middle of walking the lower devs, we would > >leave the system in an undefined state...there was no way to recover back to > >the previous state. Speaking of sets, also recognize a pattern that most > >swdev API accesses are gets or sets of port attributes, so go ahead and make > >port attr get/set the central swdev API, and convert everything that is > >set-ish/get-ish to this new API. > > > >Features/fixes that should follow from this cleanup: > > > > - solve the duplicate pkt forwarding issue > > - get/set bridge attrs, like ageing_time, from/to device > > - get/set more bridge port attrs from/to device > > > >There are some rename cleanups tagging along at the end, to give swdev > >consistent naming. > > As you can see in the switchdev patch submission history, I originally > pushed this with "swdev_" previx. Turned out people did not like that > because "sw" can be easily misunderstood as "software". I agree with this. > > > > >And finally, some much needed updates to the switchdev.txt documentation to > >hopefully capture the state-of-the-art of swdev. Hopefully, we can do a better > >job keeping this document up-to-date. > > > >Tested with rocker, of course, to make sure nothing functional broke. There > >are a couple minor tweaks to DSA code for getting switch ID and setting STP > >updates to use new API, but not expecting amy breakage there. > > > > > >Scott Feldman (18): > > switchdev: introduce get/set attrs ops > > switchdev: flesh out get/set attr ops > > switchdev: convert parent_id_get to swdev attr get > > switchdev: convert STP update to swdev attr set > > switchdev: add bridge port flags attr > > rocker: use swdev get/set attr for bridge port flags > > switchdev: add new swdev bridge setlink > > rocker: cut over to new swdev_port_bridge_setlink > > bonding: cut over to new swdev_port_bridge_setlink > > team: cut over to new swdev_port_bridge_setlink > > switchdev: remove old netdev_switch_port_bridge_setlink > > switchdev: remove unused netdev_switch_port_bridge_dellink > > switchdev: remove unused NETIF_F_HW_SWITCH_OFFLOAD > > switchdev: add new swdev_port_bridge_getlink > > rocker: cut over to new swdev_port_bridge_getlink > > switchdev: rename netdev_switch_fib_* to swdev_fib_* > > switchdev: rename netdev_switch_notifier_* to swdev_notifier_* > > switchdev: bring documentation up-to-date > > > > Documentation/networking/switchdev.txt | 426 +++++++++++++++++++++++++++----- > > drivers/net/bonding/bond_main.c | 8 +- > > drivers/net/ethernet/rocker/rocker.c | 108 +++----- > > drivers/net/team/team.c | 5 +- > > include/linux/netdev_features.h | 5 +- > > include/net/switchdev.h | 144 ++++++----- > > net/bridge/br.c | 22 +- > > net/bridge/br_netlink.c | 24 +- > > net/bridge/br_stp.c | 6 +- > > net/core/ethtool.c | 1 - > > net/core/net-sysfs.c | 10 +- > > net/core/rtnetlink.c | 9 +- > > net/dsa/slave.c | 35 ++- > > net/ipv4/fib_trie.c | 38 ++- > > net/switchdev/switchdev.c | 334 ++++++++++++++----------- > > 15 files changed, 750 insertions(+), 425 deletions(-) > > > >-- > >1.7.10.4 > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists