netdev - Re: [PATCH net-next 0/4] netlink: access functions for IP address attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150331.135856.1727900367681294283.davem@davemloft.net>
Date:	Tue, 31 Mar 2015 13:58:56 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jbenc@...hat.com
Cc:	netdev@...r.kernel.org, steffen.klassert@...unet.com,
	herbert@...dor.apana.org.au, jchapman@...alix.com,
	paul@...l-moore.com, pshelar@...ira.com, johannes@...solutions.net,
	pablo@...filter.org
Subject: Re: [PATCH net-next 0/4] netlink: access functions for IP address
 attributes

From: Jiri Benc <jbenc@...hat.com>
Date: Sun, 29 Mar 2015 16:59:22 +0200

> There are many places that read or write IP addresses to netlink attributes.
> With IPv6 addresses, every such place currently has to use generic nla_put
> and nla_memcpy. Implementing IPv6 address access functions simplify things
> and makes the code more intelligible. IPv4 address access functions has
> lesser value but it would be better to be consistent between IPv6 and IPv4
> and they still serve as documentation.
> 
> The conversion is straightforward and the resulting patches are not that
> large, thus I kept all the changes in the patches that introduce the access
> functions. If anyone prefers to split the definition of access functions and
> the conversion and/or break it out by network protocols, please let me know.
> 
> While doing the conversion, I came across ugly typecasting in
> inetpeer_addr_base and xfrm_address_t when dealing with IPv6 addresses.
> Instead of introducing more of this, I cleaned it up. Those are the first
> two patches, serving as a prerequisite to the latter two.

Looks good, series applied, thanks Jiri.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html