netdev - Re: [PATCH net 3/4 v2] ipvlan: do not use rcu operations for address list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHA+R7O7h0bbWj4mEam7vEmqkCD3a_73j7LT2A_DB3py8idEgA@mail.gmail.com>
Date:	Tue, 31 Mar 2015 11:35:59 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	Jiri Benc <jbenc@...hat.com>
Cc:	netdev <netdev@...r.kernel.org>,
	Mahesh Bandewar <maheshb@...gle.com>,
	Dan Williams <dcbw@...hat.com>
Subject: Re: [PATCH net 3/4 v2] ipvlan: do not use rcu operations for address list

(Sorry for being late)

On Sat, Mar 28, 2015 at 11:13 AM, Jiri Benc <jbenc@...hat.com> wrote:
> @@ -640,7 +640,7 @@ static void ipvlan_del_addr6(struct ipvl_dev *ipvlan, struct in6_addr *ip6_addr)
>                 return;
>
>         ipvlan_ht_addr_del(addr, true);
> -       list_del_rcu(&addr->anode);
> +       list_del(&addr->anode);
>         ipvlan->ipv6cnt--;
>         WARN_ON(ipvlan->ipv6cnt < 0);
>         kfree_rcu(addr, rcu);

But doesn't this mean kfree_rcu() can be replaced by kfree() too?
I noticed ipvlan_ht_addr_del() waits for RCU readers too.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html