netdev - Re: [PATCH net-next 0/2] ipv6: coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150331.135338.519327316482059081.davem@davemloft.net>
Date:	Tue, 31 Mar 2015 13:53:38 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ipm@...rality.org.uk
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/2] ipv6: coding style - comparisons with NULL

From: Ian Morris <ipm@...rality.org.uk>
Date: Sun, 29 Mar 2015 14:00:03 +0100

> The following patches address some coding style issues only. No
> functional changes and no changes detected by objdiff.
>
> The IPV6 code uses multiple different styles when comparing with
> NULL (I.e. x == NULL and !x as well as x != NULL and x). Generally
> the latter form is preferred according to checkpatch and so this
> changes aligns the code to this style.

Please trim your commit message lines to 80 columns in the future.

It is _extremely_ irritating to see how people type commit messages
into GUI or similar tools, and then expect that the rest of the world
will see the message formatted in the same exact way.

The only reliable way to edit and format commit log messages, so that
everyone sees something consistent, is to do so in a pure plain ASCII
text editor and use newlines to break columns at ~80 columns.

Anyways, I've applied this series, thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html