netdev - Re: [PATCH net-next] tipc: fix a slab object leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150331.231309.610369858855748160.davem@davemloft.net>
Date:	Tue, 31 Mar 2015 23:13:09 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	ying.xue@...driver.com
Cc:	jon.maloy@...csson.com, erik.hugne@...csson.com,
	netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net
Subject: Re: [PATCH net-next] tipc: fix a slab object leak

From: Ying Xue <ying.xue@...driver.com>
Date: Wed, 1 Apr 2015 09:42:50 +0800

> When remove TIPC module, there is a warning to remind us that a slab
> object is leaked like:
> 
> root@...alhost:~# rmmod tipc
> [   19.056226] =============================================================================
> [   19.057549] BUG TIPC (Not tainted): Objects remaining in TIPC on kmem_cache_close()
> [   19.058736] -----------------------------------------------------------------------------
> [   19.058736]
> [   19.060287] INFO: Slab 0xffffea0000519a00 objects=23 used=1 fp=0xffff880014668b00 flags=0x100000000004080
> [   19.061915] INFO: Object 0xffff880014668000 @offset=0
> [   19.062717] kmem_cache_destroy TIPC: Slab cache still has objects
> 
> This is because the listening socket of TIPC topology server is not
> closed before TIPC proto handler is unregistered with proto_unregister().
> However, as the socket is closed in tipc_exit_net() which is called by
> unregister_pernet_subsys() during unregistering TIPC namespace operation,
> the warning can be eliminated if calling unregister_pernet_subsys() is
> moved before calling proto_unregister().
> 
> Fixes: e05b31f4bf89 ("tipc: make tipc socket support net namespace")
> Reviewed-by: Erik Hugne <erik.hugne@...csson.com>
> Signed-off-by: Ying Xue <ying.xue@...driver.com>

This bug exists in 'net', so that's where I'm applying it.

Can you please target your patches properly, I shouldn't be
doing this kind of work for you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html