netdev - Re: [PATCH net-next v2 01/26] switchdev: introduce get/set attrs ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150401.140822.2230858157895026713.davem@davemloft.net>
Date:	Wed, 01 Apr 2015 14:08:22 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	sfeldma@...il.com
Cc:	netdev@...r.kernel.org, jiri@...nulli.us,
	roopa@...ulusnetworks.com, linux@...ck-us.net,
	f.fainelli@...il.com, sridhar.samudrala@...el.com,
	ronen.arad@...el.com
Subject: Re: [PATCH net-next v2 01/26] switchdev: introduce get/set attrs
 ops

From: sfeldma@...il.com
Date: Wed,  1 Apr 2015 03:07:37 -0700

> +int swdev_port_attr_set(struct net_device *dev, struct swdev_attr *attr)
> +{
> +	struct swdev_attr prev = *attr;
> +	int err, get_err, revert_err;
> +
> +	get_err = swdev_port_attr_get(dev, &prev);
> +
> +	err = __swdev_port_attr_set(dev, attr);
> +	if (err && !get_err && !(attr->flags & SWDEV_F_NO_RECOVER)) {
> +		/* Some err on set: revert to previous value */
> +		revert_err = __swdev_port_attr_set(dev, &prev);
> +		if (revert_err)
> +			netdev_err(dev, "Reverting swdev port attr %d failed\n",
> +				   attr->id);
> +	}
> +
> +	return err;

This style of error recovery doesn't work.

You have to have a prepare/commit model to do this sanely, because
otherwise:

1) Partial state updates can be seen by the data plane (and other
   code paths) that do not use RTNL mutex protection.

2) It is absoultely expected that if some resource allocation failed
   when switching to the new attribute value, the same exactly thing
   is extremely likely during the rollback.

So you have to code this in a way that no partial state updates are
ever visible, and also that rollbacks don't fail.

I also agree with Jamal that you should use the netlink attribute
values for these attributes rather than inventing yet another
namespace of ID numbers.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html