netdev - Re: [PATCH net-next] cxgb4: Move ethtool related code to a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427874122.31790.8.camel@perches.com>
Date:	Wed, 01 Apr 2015 00:42:02 -0700
From:	Joe Perches <joe@...ches.com>
To:	Hariprasad Shenai <hariprasad@...lsio.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net, leedom@...lsio.com,
	anish@...lsio.com, nirranjan@...lsio.com, kumaras@...lsio.com,
	swise@...ngridcomputing.com, varun@...lsio.com
Subject: Re: [PATCH net-next] cxgb4: Move ethtool related code to a separate
 file

On Wed, 2015-04-01 at 18:15 +0530, Hariprasad Shenai wrote:
> Signed-off-by: Hariprasad Shenai <hariprasad@...lsio.com>

A couple trivial bits:

> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
[]
> +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ethtool.c
> @@ -0,0 +1,915 @@
> +/*
> + *  Copyright (C) 2013-2014 Chelsio Communications.  All rights reserved.

2015 ?

[]

> +static char stats_strings[][ETH_GSTRING_LEN] = {

be nice to make this const one day.

> +	"TxOctetsOK         ",
> +	"TxFramesOK         ",
> +	"TxBroadcastFrames  ",
> +	"TxMulticastFrames  ",
> +	"TxUnicastFrames    ",
> +	"TxErrorFrames      ",


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html