netdev - Re: [PATCH net-next] net: bcmgenet: enable MoCA link state change detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGVrzca4oEs4gNmRB0frg91hheS2OT4cWrt3ni146UtCtN7LsA@mail.gmail.com>
Date:	Wed, 1 Apr 2015 05:48:27 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	Petri Gynther <pgynther@...gle.com>
Cc:	David Miller <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>,
	Jaedon Shin <jaedon.shin@...il.com>
Subject: Re: [PATCH net-next] net: bcmgenet: enable MoCA link state change detection

2015-03-31 19:44 GMT-07:00 Petri Gynther <pgynther@...gle.com>:
> On Tue, Mar 31, 2015 at 7:34 PM, Petri Gynther <pgynther@...gle.com> wrote:
>> On Tue, Mar 31, 2015 at 6:00 PM, David Miller <davem@...emloft.net> wrote:
>>> From: Petri Gynther <pgynther@...gle.com>
>>> Date: Tue, 31 Mar 2015 15:00:08 -0700 (PDT)
>>>
>>>> @@ -513,6 +522,13 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
>>>>                       dev_err(kdev, "failed to register fixed PHY device\n");
>>>>                       return -ENODEV;
>>>>               }
>>>> +
>>>> +             if (priv->hw_params->flags & GENET_HAS_MOCA_LINK_DET) {
>>>> +                     ret = fixed_phy_set_link_update(phydev,
>>>> +                                             bcmgenet_fixed_phy_link_update);
>>>
>>> This is not indented correctly.
>>>
>>> When a function call or declaration or definition spans multiple lines,
>>> arguments on the second and subsequent lines must be indented exactly
>>> to the first column after the openning parenthesis on the first line.
>>>
>>> If you are strictly using TAB characters, it is exceedingly likely
>>> that you are indenting these lines incorrectly.  You must use the
>>> appropriate number of TAB, then SPACE characters necessary to reach
>>> the correct column.
>>
>> I'm aware of the Linux indentation rules. However, if I do that in
>> this case, the second line becomes longer than 80 chars.
>
> Also, this patch still needs verification on ARM (device tree based)
> platform. Waiting to hear from Florian on that.

I am currently traveling, but I will try to give this patch a try in
the next few hours on an ARM-based platform. AFAIR, the link up/down
interrupts should work irrespective of the GENET version (1 through
4), but I will double check that too.

-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html