| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1427983654-971-11-git-send-email-eli@mellanox.com> Date: Thu, 2 Apr 2015 17:07:28 +0300 From: Eli Cohen <eli@....mellanox.co.il> To: davem@...emloft.net Cc: netdev@...r.kernel.org, idos@...laox.com, amirv@...lanox.com, Achiad Shochat <achiad@...lanox.com>, Saeed Mahameed <saeedm@...lanox.com>, Eli Cohen <eli@...lanox.com> Subject: [PATCH net-next 10/16] net/mlx5_core: Fix a bug in alloc_token From: Achiad Shochat <achiad@...lanox.com> In alloc_token(), the token '1' would be allocated twice consecutively. Signed-off-by: Achiad Shochat <achiad@...lanox.com> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com> Signed-off-by: Eli Cohen <eli@...lanox.com> --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c index 0d862696b876..697d538163f2 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c @@ -125,7 +125,10 @@ static u8 alloc_token(struct mlx5_cmd *cmd) u8 token; spin_lock(&cmd->token_lock); - token = cmd->token++ % 255 + 1; + cmd->token++; + if (cmd->token == 0) + cmd->token++; + token = cmd->token; spin_unlock(&cmd->token_lock); return token; -- 2.3.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists