netdev - Re: [PATCH net-next v2 0/12] Remove iflink field from the net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150402.140526.798085948544052697.davem@davemloft.net>
Date:	Thu, 02 Apr 2015 14:05:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nicolas.dichtel@...nd.com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next v2 0/12] Remove iflink field from the
 net_device structure

From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
Date: Thu,  2 Apr 2015 17:06:59 +0200

> The first goal of this series was to advertise the veth peer via the IFLA_LINK
> attribute, but iflink was not ready for network namespaces.
> 
> The iflink of an interface should be set to its ifindex for a physical interface
> and to another value (0 if not relevant) for a virtual interface.
> This was not the case for some interfaces, like vxlan, bond, or bridge for
> example.
> There is also a risk, if the targeted interface moves to another netns, that the
> ifindex changes without updating corresponding iflink fields (eg. vlan).
> 
> Moving the management of this property into virtual interface drivers allows to
> better handle this last case because most of virtual interface drivers have a
> pointer to the link netdevice.
> Anyway, dev->iflink value was always a copy of some internal data of the virtual
> interface driver, thus let's use these internal data directly.
> 
> So, this series removes the iflink field and let the drivers manage it.
> Only the last patch was present in the v1, but I fully rework it.

I like this a lot, series applied, thanks Nicolas.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html