netdev - Re: [PATCH net-next] ipv6: protect skb->sk accesses from recursive dereference inside the stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1427934458.25985.177.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 01 Apr 2015 17:27:38 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Cong Wang <cwang@...pensource.com>
Cc:	Hannes Frederic Sowa <hannes@...essinduktion.org>,
	netdev <netdev@...r.kernel.org>, Jiri Pirko <jiri@...nulli.us>
Subject: Re: [PATCH net-next] ipv6: protect skb->sk accesses from recursive
 dereference inside the stack

On Wed, 2015-04-01 at 17:06 -0700, Cong Wang wrote:

> Shouldn't these skb's be orphaned for tunnel cases? Or we still have
> to keep skb->sk for other valid use?

skb should not be orphaned, until the very last stage.

Many layers depend on this, really.

Simply ask the question to yourself :

What if I do not associate skb to a socket at first. What possibly
breaks ?

orphaning skb just because they traverse a tunnel would be quite
horrible.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html