lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 04 Apr 2015 01:48:14 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Alexei Starovoitov <ast@...mgrid.com>, "David S. Miller" <davem@...emloft.net> CC: Jiri Pirko <jiri@...nulli.us>, Jamal Hadi Salim <jhs@...atatu.com>, linux-api@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH net-next] tc: cls_bpf: make ingress and egress qdiscs consistent On 04/04/2015 01:26 AM, Daniel Borkmann wrote: > On 04/04/2015 01:11 AM, Alexei Starovoitov wrote: ... >> nope. will take it back. >> that doesn't work, since this check cannot be done in ingress_enqueue(), >> because it sees the pointer to first filter only, so both TCQ_F_INGRESS >> flag and CLS_REQUIRES_L2 flag need to be checked inside > > So on a quick glance, we're calling into cls_bpf_classify() in tp->classify() > (net/sched/cls_api.c +265), so all remaining filters in that list we're > traversing in cls_bpf_classify() are all BPF filters, no? I see, you mean the classifier chain, not the chain of filters within the cls_bpf classifier, ok. > Have to grab some sleep for now, will be on travel tomorrow. Anyway, worst > case it could still be refactored later. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists