netdev - Re: [PATCH] mvneta: implement SGMII-based in-band link state signaling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150402.205131.1699226515102250937.davem@davemloft.net>
Date:	Thu, 02 Apr 2015 20:51:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stsp@...t.ru
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	thomas.petazzoni@...e-electrons.com, f.fainelli@...il.com
Subject: Re: [PATCH] mvneta: implement SGMII-based in-band link state
 signaling

From: Stas Sergeev <stsp@...t.ru>
Date: Tue, 31 Mar 2015 16:24:59 +0300

> @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
> 
>  static void mvneta_mdio_remove(struct mvneta_port *pp)
>  {
> +	fixed_phy_set_link_update(pp->phy_dev, NULL);

I do not see any other driver doing this on shutdown.
Please show me why it is necessary.

And if it is, all other drivers registering a fixed phy link update
function need to be adjusted to do the same thing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html