netdev - Re: [PATCH] ethernet: e1000e: define lat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428054159.2662.82.camel@jtkirshe-mobl>
Date:	Fri, 03 Apr 2015 02:42:39 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	yanjiang.jin@...driver.com
Cc:	bruce.w.allan@...el.com, john.ronciak@...el.com,
	netdev@...r.kernel.org, jinyanjiang@...il.com
Subject: Re: [PATCH] ethernet: e1000e: define lat_ns as u64 instead of s64

On Fri, 2015-04-03 at 17:17 +0800, yanjiang.jin@...driver.com wrote:
> From: Yanjiang Jin <yanjiang.jin@...driver.com>
> 
> do_div() expects the type of "n" to be uint64_t, define "lat_ns" as
> u64 to
> avoid the below warning, also update its correlative operations and
> data.
> 
> In file included from ./arch/powerpc/include/asm/div64.h:1:0,
>                  from include/linux/kernel.h:124,
>                  from include/linux/list.h:8,
>                  from include/linux/timer.h:4,
>                  from drivers/net/ethernet/intel/e1000e/e1000.h:29,
>                  from drivers/net/ethernet/intel/e1000e/ich8lan.c:59:
> drivers/net/ethernet/intel/e1000e/ich8lan.c: In function
> 'e1000_platform_pm_pch_lpt':
> include/asm-generic/div64.h:43:28: warning: comparison of distinct
> pointer types lacks a cast [enabled by default]
>   (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
>                             ^
> drivers/net/ethernet/intel/e1000e/ich8lan.c:1016:4: note: in expansion
> of macro 'do_div'
>     do_div(lat_ns, speed);
> 
> Signed-off-by: Yanjiang Jin <yanjiang.jin@...driver.com>
> ---
>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Added intel-wired-lan mailing list (used for patches like this)
Removed LKML ... (wrong mailing list to be mailing for patches like
this)
Removed e1000-devel ... (no longer used for kernel patches)
Removed linux.nics ... (no longer used for kernel patches)

Also removed Intel developers with no interest in e1000e patches ...

Thanks Yanjiang, I will add your patch to my queue.

-- 
git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git
dev-queue

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)