netdev - Re: [RFC PATCH 1/5] geneve: remove MODULE_ALIAS_RTNL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150403121755.GC16847@nanopsycho.orion>
Date:	Fri, 3 Apr 2015 14:17:55 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	"John W. Linville" <linville@...driver.com>,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Jesse Gross <jesse@...ira.com>, Andy Zhou <azhou@...ira.com>,
	Alexander Duyck <alexander.h.duyck@...hat.com>
Subject: Re: [RFC PATCH 1/5] geneve: remove MODULE_ALIAS_RTNL_LINK from
 net/ipv4/geneve.c

Fri, Apr 03, 2015 at 01:39:19AM CEST, stephen@...workplumber.org wrote:
>On Thu,  2 Apr 2015 15:17:02 -0400
>"John W. Linville" <linville@...driver.com> wrote:
>
>> This file is essentially a library for implementing the geneve
>> encapsulation protocol.  The file does not register any rtnl_link_ops,
>> so the MODULE_ALIAS_RTNL_LINK macro is inappropriate here.
>> 
>> Signed-off-by: John W. Linville <linville@...driver.com>
>> ---
>>  net/ipv4/geneve.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/net/ipv4/geneve.c b/net/ipv4/geneve.c
>> index 5a4828ba05ad..ba5283adbee8 100644
>> --- a/net/ipv4/geneve.c
>> +++ b/net/ipv4/geneve.c
>> @@ -450,4 +450,3 @@ module_exit(geneve_cleanup_module);
>>  MODULE_LICENSE("GPL");
>>  MODULE_AUTHOR("Jesse Gross <jesse@...ira.com>");
>>  MODULE_DESCRIPTION("Driver for GENEVE encapsulated traffic");
>> -MODULE_ALIAS_RTNL_LINK("geneve");
>
>ok but then how does it get autoloaded?

There is no "struct rtnl_link_ops" defined for this. Therefore this does
not have any sense. User might use rtnl to load the module, but why?
That is clearly a bug which John is fixing.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html