netdev - Re: [Patch net] net: move fib_rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150402.205344.2010884938148163682.davem@davemloft.net>
Date:	Thu, 02 Apr 2015 20:53:44 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	xiyou.wangcong@...il.com
Cc:	netdev@...r.kernel.org, alexander.h.duyck@...hat.com, tgraf@...g.ch
Subject: Re: [Patch net] net: move fib_rules_unregister() under rtnl lock

From: Cong Wang <xiyou.wangcong@...il.com>
Date: Tue, 31 Mar 2015 11:01:46 -0700

> We have to hold rtnl lock for fib_rules_unregister()
> otherwise the following race could happen:
> 
> fib_rules_unregister():	fib_nl_delrule():
> ...				...
> ...				ops = lookup_rules_ops();
> list_del_rcu(&ops->list);
> 				list_for_each_entry(ops->rules) {
> fib_rules_cleanup_ops(ops);	  ...
>   list_del_rcu();		  list_del_rcu();
> 				}
> 
> Note, net->rules_mod_lock is actually not needed at all,
> either upper layer netns code or rtnl lock guarantees
> we are safe.
> 
> Cc: Alexander Duyck <alexander.h.duyck@...hat.com>
> Cc: Thomas Graf <tgraf@...g.ch>
> Signed-off-by: Cong Wang <xiyou.wangcong@...il.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html