netdev - Re: [PATCH net-next 1/2] ipv4: coding style: comparison for equality with NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1428079875.13180.14.camel@perches.com>
Date:	Fri, 03 Apr 2015 09:51:15 -0700
From:	Joe Perches <joe@...ches.com>
To:	Ian Morris <ipm@...rality.org.uk>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] ipv4: coding style: comparison for
 equality with NULL

On Fri, 2015-04-03 at 09:17 +0100, Ian Morris wrote:
> The ipv4 code uses a mixture of coding styles. In some instances check
> for NULL pointer is done as x == NULL and sometimes as !x. !x is
> preferred according to checkpatch and this patch makes the code
> consistent by adopting the latter form.

Thanks Ian.

>  39 files changed, 210 insertions(+), 202 deletions(-)

A change like this would generally not add or remove lines.

It'd be nice if in the future, when a substitution like
this occurs and lines counts are changed that the commit
log states why.

For this case, maybe something like:

Hoisted a few assignments from if statements while there.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html