netdev - Re: [PATCH ethtool 2/5] ethtool: Add missing Advertised speeds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428200987.11260.148.camel@decadent.org.uk>
Date:	Sun, 05 Apr 2015 03:29:47 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Amir Vadai <amirv@...lanox.com>,
	Tom Lendacky <thomas.lendacky@....com>,
	Hariprasad S <hariprasad@...lsio.com>
Cc:	netdev@...r.kernel.org, Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH ethtool 2/5] ethtool: Add missing Advertised speeds

[Adding in maintainers of drivers that can report FEC ability.]

On Sun, 2015-04-05 at 02:37 +0100, Ben Hutchings wrote:
[...]
> >  		{ 0, ADVERTISED_10000baseKX4_Full,  "10000baseKX4/Full" },
> >  		{ 0, ADVERTISED_10000baseKR_Full,   "10000baseKR/Full" },
> > +		{ 0, ADVERTISED_10000baseR_FEC,     "10000baseR/FEC" },
> 
> This is not a link mode, it's a separate capability that applies to all
> 10GBASE-R modes.  It's also meaningful for 40G and 100G modes despite
> the way we've named the flags.  Please put it in a separate section
> below the link modes.

So how about reporting FEC ability like this, using a slightly generic
heading to allow for other similar options in future?

diff --git a/ethtool.c b/ethtool.c
index 7e5fa9d..3badf5e 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -560,6 +560,12 @@ dump_link_caps(const char *prefix, const char *an_prefix, u32 mask,
 	fprintf(stdout, "\n");
 
 	if (!link_mode_only) {
+		fprintf(stdout, "	%s link options: ", prefix);
+		if (mask & ADVERTISED_10000baseR_FEC)
+			fprintf(stdout, "baseR-FEC\n");
+		else
+			fprintf(stdout, "None\n");
+
 		fprintf(stdout, "	%s pause frame use: ", prefix);
 		if (mask & ADVERTISED_Pause) {
 			fprintf(stdout, "Symmetric");
--- END ---

Ben.

-- 
Ben Hutchings
Quantity is no substitute for quality, but it's the only one we've got.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)