netdev - Re: [PATCH] mvneta: dont call mvneta_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Apr 2015 16:36:29 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	stsp@...t.ru
Cc:	netdev@...r.kernel.org, thomas.petazzoni@...e-electrons.com,
	f.fainelli@...il.com, linux-kernel@...r.kernel.org,
	stsp@...rs.sourceforge.net
Subject: Re: [PATCH] mvneta: dont call mvneta_adjust_link() manually

From: Stas Sergeev <stsp@...t.ru>
Date: Wed, 01 Apr 2015 19:23:29 +0300

> 
> mvneta_adjust_link() is a callback for of_phy_connect() and should
> not be called directly. The result of calling it directly is as below:
> ---
>  mvneta f1030000.ethernet eth1: Link is Up - Unsupported (update p
> hy.c)/Half - flow control off
> ---
> 
> This is because initially the struct phy_device is created with
> invalid parameters. phylib calls adjust_link() only when the parameters
> are validated, but calling it by hands may happen too early.
> 
> CC: Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
> CC: netdev@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: Florian Fainelli <f.fainelli@...il.com>
> 
> Signed-off-by: Stas Sergeev <stsp@...rs.sourceforge.net>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html