netdev - Re: [PATCH net-next v1] bonding: LACP state machine variable "port-moved" is never set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150406.170158.894434269756337066.davem@davemloft.net>
Date:	Mon, 06 Apr 2015 17:01:58 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	maheshb@...gle.com
Cc:	j.vosburgh@...il.com, andy@...yhouse.net, vfalico@...il.com,
	nikolay@...hat.com, maze@...gle.com, netdev@...r.kernel.org,
	edumazet@...gle.com
Subject: Re: [PATCH net-next v1] bonding: LACP state machine variable
 "port-moved" is never set

From: Mahesh Bandewar <maheshb@...gle.com>
Date: Fri,  3 Apr 2015 13:54:10 -0700

> The state-machine checks for the presence of this flag and attempts
> to clear it but the value is never set. So why have it?
> 
> Signed-off-by: Mahesh Bandewar <maheshb@...gle.com>

This commit log message doesn't sound like you are asserting that this
adjustment should made.

It sounds more like you actually aren't really sure, and you're asking
folks on the list what the intent of this code is.

I'm not applying this until the commit log is adjusted to show that
you are absolutely certain that this change is valid.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html