netdev - Re: [PATCH v2] net: dsa: fix filling routing table from OF description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150406.173159.204611711817722389.davem@davemloft.net>
Date:	Mon, 06 Apr 2015 17:31:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	pavel.nakonechny@...tlab.ru
Cc:	netdev@...r.kernel.org, joe@...ches.com, grant.likely@...aro.org,
	robh+dt@...nel.org, f.fainelli@...il.com, fabf@...net.be,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: dsa: fix filling routing table from OF
 description

From: Pavel Nakonechny <pavel.nakonechny@...tlab.ru>
Date: Sun, 05 Apr 2015 00:46:21 +0300

> According to description in 'include/net/dsa.h', in cascade switches
> configurations where there are more than one interconnected devices,
> 'rtable' array in 'dsa_chip_data' structure is used to indicate which
> port on this switch should be used to send packets to that are destined
> for corresponding switch.
> 
> However, dsa_of_setup_routing_table() fills 'rtable' with port numbers
> of the _target_ switch, but not current one.
> 
> This commit removes redundant devicetree parsing and adds needed port
> number as a function argument. So dsa_of_setup_routing_table() now just
> looks for target switch number by parsing parent of 'link' device node.
> 
> To remove possible misunderstandings with the way of determining target
> switch number, a corresponding comment was added to the source code and
> to the DSA device tree bindings documentation file.
> 
> This was tested on a custom board with two Marvell 88E6095 switches with
> following corresponding routing tables: { -1, 10 } and { 8, -1 }.
> 
> Signed-off-by: Pavel Nakonechny <pavel.nakonechny@...tlab.ru>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html