netdev - Re: [PATCH net-next 1/4] via-rhine: commit receive buffer address before descriptor status update.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1428445367.25985.214.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Tue, 07 Apr 2015 15:22:47 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexander Duyck <alexander.h.duyck@...hat.com>
Cc:	David Miller <davem@...emloft.net>, romieu@...zoreil.com,
	netdev@...r.kernel.org, nix@...eri.org.uk, rl@...lgate.ch,
	gurligebis@...too.org
Subject: Re: [PATCH net-next 1/4] via-rhine: commit receive buffer address
 before descriptor status update.

On Tue, 2015-04-07 at 15:12 -0700, Alexander Duyck wrote:
> On 04/07/2015 02:54 PM, Eric Dumazet wrote:

> > To be fair, only 2 drivers currently use dma_wmb()
> 
> Hey, I got at least 4..  :-)  I only got around to patching 3 Intel 
> drivers and one RealTek since that is what I had to test with.  I was 
> honestly hoping there would be more interest from other developers to 
> pick this up and update their drivers to avoid unnecessary barriers but 
> it doesn't look like I have had much luck on that front.

Strange I see only 2 drivers here, and no Intel ones :

# git grep -l dma_wmb drivers/net
drivers/net/ethernet/amd/xgbe/xgbe-dev.c
drivers/net/ethernet/realtek/r8169.c

I probably missed something ;)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html