lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Apr 2015 15:21:00 +0200 From: Geert Uytterhoeven <geert@...ux-m68k.org> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Linux-sh list <linux-sh@...r.kernel.org> Subject: Re: [PATCH] sh_eth: move inline functions to the header file Hi Sergei, On Sun, Apr 5, 2015 at 11:13 PM, Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote: > The explicitly inline functions belong to the header files, so move > cpu_to_edmac() and edmac_to_cpu() into the driver header. Why do they belong in the header file? Are they (planned to be) used by another source file (EtherAVB?)? Currently no other source file besides sh_eth.c includes sh_eth.h, so IMHO sh_eth.h could just be absorbed by sh_eth.c. > While at it, make these functions return 'u32' instead of '__u32'. That change is fine for me. > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists