netdev - Re: [PATCH 3/4] netfilter: Pass socket pointer down through okfn().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150407.115934.1965685795824815835.davem@davemloft.net>
Date:	Tue, 07 Apr 2015 11:59:34 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
	pablo@...filter.org, jiri@...nulli.us
Subject: Re: [PATCH 3/4] netfilter: Pass socket pointer down through okfn().

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Tue, 07 Apr 2015 16:44:29 +0200

> On So, 2015-04-05 at 22:19 -0400, David Miller wrote:
>> --- a/include/linux/netfilter.h
>> +++ b/include/linux/netfilter.h
>> @@ -54,7 +54,7 @@ struct nf_hook_state {
>>  	struct net_device *in;
>>  	struct net_device *out;
>>  	struct sock *sk;
>> -	int (*okfn)(struct sk_buff *);
>> +	int (*okfn)(struct sock *, struct sk_buff *);
>>  };
> 
> If we give okfn the signature int (*okfn)(struct nf_hook_state *); then
> we would not need to touch anything else to enhance this.
> 
> What do you think?

We do not want nf_hook_state being an argument for non-netfilter output
functions in the various protocols.

So this is a terrible idea.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html