lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Apr 2015 11:26:12 -0600 From: Jason Gunthorpe <jgunthorpe@...idianresearch.com> To: Michael Wang <yun.wang@...fitbricks.com> Cc: Roland Dreier <roland@...nel.org>, Sean Hefty <sean.hefty@...el.com>, linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org, netdev@...r.kernel.org, Hal Rosenstock <hal.rosenstock@...il.com>, Tom Tucker <tom@...ngridcomputing.com>, Steve Wise <swise@...ngridcomputing.com>, Hoang-Nam Nguyen <hnguyen@...ibm.com>, Christoph Raisch <raisch@...ibm.com>, Mike Marciniszyn <infinipath@...el.com>, Eli Cohen <eli@...lanox.com>, Faisal Latif <faisal.latif@...el.com>, Upinder Malhi <umalhi@...co.com>, Trond Myklebust <trond.myklebust@...marydata.com>, "J. Bruce Fields" <bfields@...ldses.org>, "David S. Miller" <davem@...emloft.net>, Ira Weiny <ira.weiny@...el.com>, PJ Waskiewicz <pj.waskiewicz@...idfire.com>, Tatyana Nikolova <Tatyana.E.Nikolova@...el.com>, Or Gerlitz <ogerlitz@...lanox.com>, Jack Morgenstein <jackm@....mellanox.co.il>, Haggai Eran <haggaie@...lanox.com>, Ilya Nelkenbaum <ilyan@...lanox.com>, Yann Droneaud <ydroneaud@...eya.com>, Bart Van Assche <bvanassche@....org>, Shachar Raindel <raindel@...lanox.com>, Sagi Grimberg <sagig@...lanox.com>, Devesh Sharma <devesh.sharma@...lex.com>, Matan Barak <matanb@...lanox.com>, Moni Shoua <monis@...lanox.com>, Jiri Kosina <jkosina@...e.cz>, Selvin Xavier <selvin.xavier@...lex.com>, Mitesh Ahuja <mitesh.ahuja@...lex.com>, Li RongQing <roy.qing.li@...il.com>, Rasmus Villemoes <linux@...musvillemoes.dk>, Alex Estrin <alex.estrin@...el.com>, Doug Ledford <dledford@...hat.com>, Eric Dumazet <edumazet@...gle.com>, Erez Shitrit <erezsh@...lanox.com>, Tom Gundersen <teg@...m.no>, Chuck Lever <chuck.lever@...cle.com> Subject: Re: [PATCH v2 03/17] IB/Verbs: Use management helper cap_ib_mad() for mad-check On Tue, Apr 07, 2015 at 02:30:22PM +0200, Michael Wang wrote: > - if (rdma_node_get_transport(device->node_type) != RDMA_TRANSPORT_IB) > - return; > - > if (device->node_type == RDMA_NODE_IB_SWITCH) { > start = 0; > end = 0; > @@ -3069,6 +3066,9 @@ static void ib_mad_init_device(struct ib_device *device) > } > > for (i = start; i <= end; i++) { > + if (!cap_ib_mad(device, i)) > + continue; > + I would prefer to see these changes in control flow as dedicated patches, at the top of your patch stack. For this kind of work a patch should be mechanical changes only, it is easier to review that way. Same comment applies throughout. Jason -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists