netdev - re: udp_tunnel: Pass UDP socket down through udp_tunnel{, 6}_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Apr 2015 21:48:05 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	davem@...emloft.net
Cc:	netdev@...r.kernel.org,
	Hannes Frederic Sowa <hannes@...essinduktion.org>
Subject: re: udp_tunnel: Pass UDP socket down through udp_tunnel{,
 6}_xmit_skb().

Hello David Miller,

The patch 79b16aadea32: "udp_tunnel: Pass UDP socket down through
udp_tunnel{, 6}_xmit_skb()." from Apr 5, 2015, leads to the following
static checker warning:

	net/ipv4/ip_tunnel.c:785 ip_tunnel_xmit()
	error: NULL dereference inside function.

net/ipv4/ip_tunnel.c
   781                  kfree_skb(skb);
   782                  return;
   783          }
   784  
   785          err = iptunnel_xmit(NULL, rt, skb, fl4.saddr, fl4.daddr, protocol,
                                    ^^^^
This doesn't work.  It will Oops in iptunnel_xmit() when it does
sock_net(sk).

   786                              tos, ttl, df, !net_eq(tunnel->net, dev_net(dev)));
   787          iptunnel_xmit_stats(err, &dev->stats, dev->tstats);
   788  
   789          return;

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html